adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
572 stars 34 forks source link

Adapt to new Cascadia release scheme #34

Closed Finii closed 4 years ago

Finii commented 4 years ago

[why] Microsoft changed the release mechanism. Instead of directly releasing the font files they are packed into a zip archive now, in different formats.

Further complication is that the release version name is also in the zip archive name, so we can not directly download it anymore in a generic way.

[how] First fetch the latest-release website and try to cut out the latest release's directory and release package name.

Use that to download the archive. Unpack it and pull the font out.

This is all not so nice, but I see no other way to stay halfway generic with their release scheme. And this just hopes, that they do not change it again the next time :-/

This fixes #33

Please check if the resulting font(s) are ok @chunliu. I will generate a new release package if you find this working.

chunliu commented 4 years ago

Thanks @Finii for investigating it. The fonts are working fine for me. I think it is good for a new release.

Finii commented 4 years ago

Hmm, the new powerline looks not very nice. The diagonals are too long?

Comparison of v1910.04.1-2-g75828d2 (wow that is old) top and v1911.21.3-2-g734c02e bottom: new new2

Finii commented 4 years ago

From the logfile:

Check for preexisting glyphs

Run grep 'Found existing' process*.log
process.log:Updating glyph: <Glyph uniE0A0 in font PowerlineSymbols> uniE0A0 putting at: E0A0  Found existing Glyph at E0A0. Skipping...
process.log:Updating glyph: <Glyph uniE0A1 in font PowerlineSymbols> uniE0A1 putting at: E0A1  Found existing Glyph at E0A1. Skipping...
process.log:Updating glyph: <Glyph uniE0A2 in font PowerlineSymbols> uniE0A2 putting at: E0A2  Found existing Glyph at E0A2. Skipping...
process.log:Updating glyph: <Glyph uniE0B0 in font PowerlineSymbols> uniE0B0 putting at: E0B0  Found existing Glyph at E0B0. Skipping...
process.log:Updating glyph: <Glyph uniE0B1 in font PowerlineSymbols> uniE0B1 putting at: E0B1  Found existing Glyph at E0B1. Skipping...
process.log:Updating glyph: <Glyph uniE0B2 in font PowerlineSymbols> uniE0B2 putting at: E0B2  Found existing Glyph at E0B2. Skipping...
process.log:Updating glyph: <Glyph uniE0B3 in font PowerlineSymbols> uniE0B3 putting at: E0B3  Found existing Glyph at E0B3. Skipping...
process.log:Updating glyph: <Glyph uni2262 in font Hack-Regular> uni2262 putting at: 2262  Found existing Glyph at 2262. Skipping...
process.log:Updating glyph: <Glyph uni2263 in font Hack-Regular> uni2263 putting at: 2263  Found existing Glyph at 2263. Skipping...
process.log:Updating glyph: <Glyph uni276F in font Hack-Regular> uni276F putting at: 276F  Found existing Glyph at 276F. Skipping...

The three from Hack where always preexisting, now we virtually skip all from PowerlineSymbols.

For my usual workspace the font looks ok now. Will check on Windows now, and with VisualCode.

Finii commented 4 years ago

Visual~Code~Studio 19 looks good for me. I have no powerline setup for Windows, but if it works with my zsh in a terminal under gnome, I guess it will work in PowerShell under Windows just the same.

-=> releasing

Finii commented 4 years ago

Thank you @chunliu for alerting me of the new Cascadia release. I would not have noticed it without you :grimacing:

chunliu commented 4 years ago

You are welcome @Finii. Appreciate all your effort.