search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Error in download script and request #40

Closed lfom closed 4 years ago

lfom commented 4 years ago

Thanks for your post and the repo. Although the README does not explain how to actually patch the fonts, your post and (hidden) workflow helped a lot. I think there is an error in the script that downloads the source fonts for patching tho, two files aren't download correctly, these two lines are missing ?raw=true so they would be downloaded correctly.

I also would like to ask if I can create a repo based on yours with a shell script to patch any font. Cloning the whole Nerd Fonts just to patch a few fonts seems like an overkill.

Regards

Finii commented 4 years ago

Sorry, I'm out of office for another 2 weeks and can not look into this now.

adam7 commented 4 years ago

Hi @lfom Glad this was of some use to you, if you'd like to submit a pr for the script changes I'd be very happy :) Feel free to create away, I must add a license to this repo to make it more obvious that everyone's free to do that.

lfom commented 4 years ago

PR sent, I will wait for the license. Thanks again.

adam7 commented 4 years ago

You're welcome, MIT license is in place now so I'm closing this