adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Include light font weight in Delugia #45

Closed offero closed 3 years ago

offero commented 3 years ago

Terminal config:

           "fontFace" : "Delugia Nerd Font",
            "fontWeight": "light",
            "fontSize" : 10,

Results in bold font

Finii commented 3 years ago

There is no Delugia Nerd Font light. Which 'Terminal' are you using, that you can select 'light'? I can't.

Usually you can select bold or italic even if not supplied by the font, but I never heard of an autogenerated light.

Screenshot from 2020-09-28 08-35-43

offero commented 3 years ago

I'm using the latest Cacadia Code PL

Terminal: https://github.com/microsoft/terminal

Settings:

            "fontFace" : "Cascadia Mono PL",
            "fontWeight": "light",
            "fontSize" : 10,

image

Finii commented 3 years ago

For questions about Cascadia Code, please head over to https://github.com/microsoft/cascadia-code.

If you open Delugia in your font settings dialog, note that there is no light or other weights, just regular.

Capture

I guess you manually typed in light in the terminal settings file?

offero commented 3 years ago

Gotcha. Consider this issue a request to include the light variant then.

Finii commented 3 years ago

In fact I noticed this would be easy (while working on Artur's PR). What shall we do? All (now 5) fonts also in light? Where to end, there are 5 weights for each ... :grimacing:

Finii commented 3 years ago

Explanation: I think we can not handle the multi-weight font files; either because a fontforge limitation or because limited know how to operate that on my side. But we can generate dedicated files for each weight, as Microsoft does in its static/ subdir.

adam7 commented 3 years ago

I think you're right @Finii we should generate all the fonts 😬

Finii commented 3 years ago

I guess this can be closed? Please reopen if this is still an issue with release v2105.24.2.