search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
572 stars 34 forks source link

VSCode: wrong display 3 backtick characters #5

Closed thuandt closed 5 years ago

thuandt commented 5 years ago

New font version image

Old font version image

Zireael commented 5 years ago

I have the same issue. The backtick ` used in JavaScript for string interpolation has no 'width' and is displayed on top of the next character.

adam7 commented 5 years ago

Can you check if the version from this build fixes the issue?

https://github.com/adam7/delugia-code/runs/255214512

thuandt commented 5 years ago

@adam7 Thanks for your help, but it's not working. Same issue

khuongduybui commented 5 years ago

Uhmmm it's even worse. Let's just fix one backtick first: image

khuongduybui commented 5 years ago

I bisected all the way back, this is the last-known-good version: https://github.com/adam7/delugia-code/commit/562eb8202b02100375ec0247c187ad81acbf6efc/checks?check_suite_id=245257563

adam7 commented 5 years ago

@khuongduybui So that's the last build before the latest version of Cascadia was released

khuongduybui commented 5 years ago

Correct. But I checked the latest version of upstream and it does not have that issue (as you can see in the screenshot)