search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Generate Delugia font for Cascadia Mono PL #50

Closed ArturDorochowicz closed 3 years ago

ArturDorochowicz commented 3 years ago

@adam7 Would you be open to extending the project to produce a Delugia font from Cascadia Mono?

Cascadia Mono is the version of Cascadia Code without ligatures. Supporting it may be useful for those environments that don't allow disabling ligatures (e.g. Windows Terminal).

I have a commit with these changes here: https://github.com/ArturDorochowicz/delugia-code/commit/a5ac037f5630df6038227c1bd38127bfc3da616b and I could open a PR if you're OK with this.

Finii commented 3 years ago

Hej Artur!

These three faces are generated:

Delugia Nerd Font Powerline Basic glyphs, monospaced font Delugia Nerd Font Complete All Nerd Fonts glyphs, monospaced font Delugia Nerd Font Book All Nerd Fonts glyphs, proportional font (not recommended for coding/console)

We already generate monospaced fonts. How would the fonts gerenated from Cascadia Mono differ? Can you post an image for comparison?

Thanks, Fini

Finii commented 3 years ago

Duh, .... it has no ligatures.

Sorry, I need more :coffee:, its 6 oclock in the morning here ;-)

So they should not be called Mono but NonLigature or something?

ArturDorochowicz commented 3 years ago

Duh, .... it has no ligatures.

Yes, no ligatures. Here's a screenshot from Windows Terminal with the results of the proposed change ("Mono" version at the bottom). Capture

So they should not be called Mono but NonLigature or something?

Up to you. I said Mono because the original is called Cascadia Mono.

Finii commented 3 years ago

Hmm, the ligatures seem to be correct (i.e. 2 spaces wide). You are not complaining that the ligatures are rendered wrongly, right?

I believe you do not like the (to have) ligatures but the characters of the font and PowerShell is not giving you options?

(I have looked at your commit and it looked good, btw).

adam7 commented 3 years ago

@Finii Cascadia now includes a specific ligature-free version of Cascadia called CascadiaMono in the release zip file. @ArturDorochowicz would like to bundle that into so we'd have Delugia.Mono.Nerd.Font.ttf etc. Agree the commit looks good from a quick review, I'd be happy to get a PR for this 👍

Finii commented 3 years ago

:+1: (note some comments in Arturs commit, but that is negligible)

ArturDorochowicz commented 3 years ago

@ArturDorochowicz would like to bundle that into so we'd have Delugia.Mono.Nerd.Font.ttf etc.

@adam7 I don't quite follow. You want dots instead of spaces in the file name?

PR opened: #51

Finii commented 3 years ago

The blancs become dots automatically on publish ;)

Finii commented 3 years ago

Merged - closing.