search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Generate Delugia font from CascadiaMonoPL #51

Closed ArturDorochowicz closed 3 years ago

ArturDorochowicz commented 3 years ago

This PR extends font generation workflow to produce "Delugia Mono" font from CascadiaMonoPL.

Cascadia Mono is the version of Cascadia Code without ligatures. Supporting it may be useful for those environments that don't allow disabling ligatures (e.g. Windows Terminal).

The workflow now produces two additional fonts:

Finii commented 3 years ago

Code looks ok for me.

But maybe the README.md should reflect what is released (These three faces are generated: cough) and explain what "mono" means in our context (it means no ligatures).

In mho it can be pulled after the docs have been fixed.

ArturDorochowicz commented 3 years ago

But maybe the README.md should reflect what is released (These three faces are generated: cough) and explain what "mono" means in our context (it means no ligatures).

@Finii I have updated the readme. Let me know if it's ok.

Finii commented 3 years ago

Ah, the REAME is nice. :+1:

But while running it locally it noticed these intermediate files:

-rw-rw-r-- 1 fini fini  411084 Feb 15 22:33 'Cascadia Mono PL Nerd Font Mono.ttf'
-rw-rw-r-- 1 fini fini  436780 Feb 15 22:31 'Caskaydia Cove PL Nerd Font Mono.ttf'

The is the result from font-patcher. The non-mono version got renamed to Caskaydia while the (unknown to font-patcher) MONO version was not renamed but just the Nerd names added. This is the reason why we had the globbing (*) in the filesnames before. When we update font-patcher the fixed names might bite us.

Finii commented 3 years ago

Hope ypu don't mind me mingling in your PR.

I will pull now (manually, to get a FF pull, what is wrong with the default settings here) and tag a new release.

Finii commented 3 years ago

Great, release is out.

Thank you very much for the input and work/help!