search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Combine workflows #57

Closed sitiom closed 3 years ago

sitiom commented 3 years ago

Truly resolves #48.

One thing I overlooked at #56 is that events triggered by the GITHUB_TOKEN will not create a new workflow run (as stated here). This means that the build workflow will not be triggered when the check-for-new-cascadia workflow creates a new tag because GITHUB_TOKEN was used to create it. This limitation also means that Workflow Dispatch would also require a personal access token to dispatch other workflows (it is a required input for the action).

This fixes the problem by combining the two workflows together so that you do not need to call the other workflow which requires your token.

adam7 commented 3 years ago

Good work spotting the issue with Workflow Dispatch, I didn't realise it had the same restriction,