adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
571 stars 33 forks source link

v2105.24.1 and up are slightly more stretched on vertical axis #61

Closed LuanVSO closed 3 years ago

LuanVSO commented 3 years ago

these are both Delugia complete v2105.24.2 (right): image image now cascadia code (left) and delugia v2105.24.2 (right): image image

Finii commented 3 years ago

Hej Luan,

I can not reproduce. It put some fonts next to each other in Writer, in separate Columns (where they can have individual line heights):

image

Both dashed line pairs are 121px apart, so all 4 blocks have the same height.

The font files I used are:

Having a closer look at your images I assume you have accidentally swapped them. Anyhow, here are both images with some added lines at 250%:

Your bottom image: s2

All looks fine.

Your top image: s1

Here I shifted the right part (where the vertical dashed blue line is) up by 2 pixels. The vertical height is identical in both fonts, just Terminal seems to start the right font (Delugia?) a bit higher in the window?

My conclusion from this examination is:

Is this what you mean?

Edit: Added information about 121px height

Finii commented 3 years ago

In fact there is even no 2px shift. I already had it in the image above...:

image

After the shift the window title is of same height, so what you did is just shift one of the windows.

I see no difference here at all. Please reopen if you still believe there is a problem and can show some conclusive images, Thank you for filing the issue, though :-)

Finii commented 3 years ago

Had another look...

I believe now I know what you mean: image

Finii commented 3 years ago

I still can not reproduce with Writer: image

Capital-height is the same here.

Now in the Gnome Terminal:

Cascadia: Screenshot from 2021-07-02 08-20-22

Delugia: Screenshot from 2021-07-02 08-20-12

Looks a bit different, esp Delugia's bold is less more bold. But then, I do not have Delugia Bold installed, so it is autogenerated, while it is embedded in the Cascadia font file.

Having a closer look:

image

Yes, the capital height is different! (slightly)

Edit: Correct less -> more

Finii commented 3 years ago

Ah ha!

Now I used ttf/static/CascadiaCodePL-Regular.ttf, and its height is identical to DelugiaComplete.ttf:

c2_1

c2_2

Here a magnified view:

image


Conclusion:

So there is a capital height difference between the all-in-one CascadiaCodePL.ttf and the Microsoft supplied static version CascadiaCodePL-Regular.ttf

Delugia is based on the static Cascadia Code font, and there is no height difference between the two. Delugia up to v2105.24 based on the dynamic CascadiaCodePL.ttf font.

The switch to the static fonts has been necessary because we can not patch in all the other glyphs while keeping the font dynamic. Read 'can not' as would require considerable amounts of time.

I believe one can live with the slightly different height rendering. Different... Well, this is Delugia and it renders as high as Delugia renders ;-)

trallnag commented 3 years ago

Just to add to this: The type designer of Cascadia is also saying that the static versions of Cascadia differ quite strongly from the variable TTF versions