search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
572 stars 34 forks source link

lowercase letters in cursive don't match up with those in cascadia code #65

Closed jiyometrik closed 3 years ago

jiyometrik commented 3 years ago

Issue

The lowercase letters in Delugia Code Italic (Cursive) don't match up with their counterparts in Cascadia Code Italic.

Reason

I think this improvement made would be beneficial to many Delugia Code users who want consistency between Delugia and Cascadia (including me!).

Screenshots

Cascadia Code image

Delugia Code image

Finii commented 3 years ago

Cascadia Code has in fact two italic faces (one reachable via open type stylistic set iirc). Will investigate on the weekend.

Finii commented 3 years ago

From your screenshot the lower case f and r are easily discernible.

As I already pointed out, the curly version that you attribut to Cascadia is not the normal Cascadia glyph but only in when a stylistic set is activated (screenshot of Cascadias landing page):

image

I believe this has been changed with the newest (2106.17) release of Cascadia related to Issue https://github.com/microsoft/cascadia-code/issues/468 (for example have a look at comment https://github.com/microsoft/cascadia-code/issues/468#issuecomment-850297845).

So I think the consistency is already existing, but you do not compare against the newest Cascadia Code release.

(I did not check if SS01 is available in Delugia, but that would be another story anyhow. As we do not touch existing glyphs at all, I can not imaging that we deviate in that regard).

Finii commented 3 years ago

Check here https://github.com/microsoft/cascadia-code/releases/tag/v2106.17 for features and changes of the 2106.07 Cascadia release... ;) (forgot to include the link in the comment above)

Finii commented 3 years ago

The SS01 is embedded also in Delugia.

You need to activate SS01 if you like the more curly versions more. This is consistent with Cascadia.

Example (note ticked Stylistic Set 1 in the dialog to the right):

image