search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Wrong version encoded in font files #66

Closed Finii closed 2 years ago

Finii commented 3 years ago

While examining the v2106.17 release files, I noticed that the version inside the files is wrong:

image

It shows as v2105.24.2-1-ga2e91f1 which is technically correct, but wrong.

Strangely the release shows the correct tag:

image

This means the tagging and releasing were performed instead as releasing and then tagging.

Maybe the reason is the merge commit and that I did it with the web GUI stuff where nobody knows what happenes ;) usually I use git push --follow-tags to transfer a new commit and its tags in one go to create a new release.

Unfortunately the workflow changed a bit and I did only look superficial on the code.

Not sure if we want/need to re-release with correct version number embedded?

Finii commented 3 years ago

Oh, ... I am so bad with web/GUI stuff, tig shows that the version tag is indeed 100% correct and I just missed to add a new tag when merging (did I mention that I hate merge commits ;)

image