adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Is this glyph being displayed too small? #69

Closed trallnag closed 2 years ago

trallnag commented 2 years ago

Introduction

Hello, first: Thanks for the project. I think it is a great idea to have many more decentralized but also automated projects turning fonts into nerd fonts instead of a single big one. And this shows how it can be done

Question

I have noticed that basically all nerd font specific glyphs are being displayed very small compared to official unicode glyphs. It looks like all glyphs are occupying a single "width".

image

echo -e "\uf015HALLO\n🚀HALLO"

Is this expected? Is it the same for other users?

Environment

Finii commented 2 years ago

The rocket U+1f680 🚀is in some other font.

Delugia's range is limited to U+ffff and does not contain any codes beyond (which is a deliberate decision).

Delugia is usually a monospaced font, that means that all glyphs have the same width.

Lets have a look which versions we generate:

So propapbly you do not want the monospaced but the proportional font. With that font the icons are as big as they were in the sources, so probably bigger (wider) than a capital H. Did you try that font?

Edit: Just change emphasis in version list

trallnag commented 2 years ago

Ah I am using Delugia Complete. I will try out Delugia Book, report back and close this issue. thanks already.

Basically "Complete" is the equivalent of "Mono" in Nerd Font fonts

Finii commented 2 years ago

Great. :+1:

Also compare #53 for some information. We improved the handling after that issue a bit (PR pending at Nerd Fonts).

Edit: Use github parlance PR instead of MR ;-)

trallnag commented 2 years ago

Just as wished 👍

image

Finii commented 2 years ago

That is the reason we decided to have different naming scheme than Nerd Fonts; to be free to handle stuff as we/our users see fit.

I close this, please reopen if you think something is still amiss.

Thanks for the report.