adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
572 stars 34 forks source link

Font name isn't updated #7

Closed clairernovotny closed 5 years ago

clairernovotny commented 5 years ago

After #6, the font name isn't showing up correctly in Windows:

image

The full name is "Delugia Nerd Font" and it does show up that way in Visual Studio.

image

Looks like a disconnect between the Windows display name and the font name?

clairernovotny commented 5 years ago

Hmm, it's worse than that. VS shows it as Delugia Nerd Font but for VS Code you need to use CascadiaCode Nerd Font Mono.

VS actually doesn't find the font. So it shows the right name in the drop down but it looks like this (looks like Courier New as a fallback):

image

adam7 commented 5 years ago

Can you confirm this is fixed now @onovotny

clairernovotny commented 5 years ago

The latest build from master appears to show the correct name in Windows and VS. It also shows as monospace:

image

image

adam7 commented 5 years ago

Awesome closing