adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Installed as 2 different fonts #72

Closed rashil2000 closed 2 years ago

rashil2000 commented 2 years ago

Hey!

I used to painstakingly patch Cascadia Code manually to include Nerd glyphs, before I found this repo. Many thanks for this!

But I'm facing a similar issue that I faced with Caskaydia (nerd font version of Cascadia) - when installing, two fonts show up:

image

image

image

Is this expected? Shouldn't the Light variant show up along with Regular and Bold in the Delugia font itself?


For now, I manually edited family name in the font files DelugiaCompleteLight.ttf and DelugiaCompleteLight-Italic.ttf from "Delugia Light" to "Delugia" in Fontforge and then installed it to solve the issue.

Screenshot 2021-12-06 005333 Screenshot 2021-12-06 005343

Finii commented 2 years ago

Thanks for reporting. I can fix it for Delugia in the afternoon.

To fix it generally for font-patcher we need something like #706 . In fact Cascadia (and other full blown fonts) and their problems with font-patcher is my driver for that time consuming project.

rashil2000 commented 2 years ago

Thank you for the info!

Finii commented 2 years ago

Well, now it is fixed.

In applications that support Typographic Families they will show up as packs of 6, in 'old fashioned' applications they will show up as 6 times 4 (regular, bold, italic, bold italic) and 6 times 2 (light, light italic).

image

I will upload the code and refresh the repo ... soon ;)

rashil2000 commented 2 years ago

Thanks again for the fix, and for Delugia 😅

Should I close this?

Finii commented 2 years ago

Will be auto-closed by the merge... :-)

Finii commented 2 years ago

Hmm, although this fixes it, it is not as intended, ... will push another tweak