adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Update font when nerd fonts updated #76

Closed latipun7 closed 1 year ago

latipun7 commented 2 years ago

As I understand, this font updated when new cascadia code updated. But, when new nerd fonts updated with its added icons and bug fixes, this font not updated, just waiting for new cascadia code.

Please support updating font for the most updated cascadia code and nerd fonts.

Thank you.

Finii commented 2 years ago

Well, the last Nerd Fonts updates just brought the features we have here to Nerd Fonts. With Caskaydia Cove 2.2.2 I guess it is en par with Delugia.

Delugia has been the driver, the test bed of the new Nerd Font features; but that means Delugia uses a modified patching process. You are right we should get rid of that (see also #75).

And I can work only on one project at a time :grimacing: but in principle you are right. Just getting out 2.2.0 and the bugfix releases over there took an extreme amount of time.

trallnag commented 1 year ago

With Caskaydia Cove 2.2.2 I guess it is en par with Delugia.

Is it though? Comparing I am still seeing a difference

Caskaydia Cove latest version

3

Delugia Book latest version

4

Finii commented 1 year ago

Hmm, I just found 4 commits in my local repo, that are not here :sob: Too long done nothing. Can't remember...

image

Finii commented 1 year ago

With Caskaydia Cove 2.2.2 I guess it is en par with Delugia.

Is it though? Comparing I am still seeing a difference

That might be the here-missing PPEM fix https://github.com/ryanoasis/nerd-fonts/pull/761

image From the CI run here

Finii commented 1 year ago

@latipun7 @trallnag Maybe you want to / can check Delugia after the update.

The artifacts can be downloaded here: https://github.com/adam7/delugia-code/actions/runs/3137726398

trallnag commented 1 year ago

I checked and there is still a difference. In the Windows font preview I noticed that Delugia has "TrueType Outlines" while Caskaydia uses "PostScript Outlines".

caskaydia

delugia

ezgif com-gif-maker

Failing to compare it properly with the original Cascadia because for that font way more weights are showing up in the preview. So it's difficult to overlay them.

Before I tested it in Windows Terminal and there I'm seeing other differences. Looking through the projects issues suggests that the font rendering in WT is not perfect.


Crazy and unexpected (to me) how complex non-bitmap fonts are.

trallnag commented 1 year ago

Here is the difference in Windows Terminal on font 9 with Clear Type:

ezgif com-gif-maker

Anyway I don't want anyone to fix this or something like that. It is just interesting

Delugia certainly seems closer to the original in WT. But again, this could be due to WT rendering and look completely different in another app.

Finii commented 1 year ago

Excellent report :+1:

Anyway I don't want anyone to fix this or something like that. It is just interesting

Delugia certainly seems closer to the original in WT. But again, this could be due to WT rendering and look completely different in another app.

I guess you compare with Cascadia Code TTF? The Caskaydia Cove is OTF, which has more rendering information apart from the glyph shapes.

Finii commented 1 year ago

Failing to compare it properly with the original Cascadia because for that font way more weights are showing up in the preview.

Probably you use the Variable Font version of Cascadia. You can think of that as the 'Regular' font but added mathematical routines to calculate other weights on the fly (by the rendering engine), so that there is only one set of outlines and not one set for each weight.

Crazy and unexpected (to me) how complex non-bitmap fonts are.

Almost nothing is 'hard coded' in the fonts, there are sets on sets of instructions and rules one can put into the file; code to be executed on render time... Plus there are 3 major players (Apple, MS, Adobe) that have different opinions and implement their own 'sets' :grimacing: ... well it got better over the last years.