search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Powerline Extra Symbols are not proportional in Delugia Book #80

Open PROxZIMA opened 1 year ago

PROxZIMA commented 1 year ago

I'm using OpenType.js via https://proxzima.dev/CharacterMap/ to preview the unicodes.

Delugia version: v2111.01.2

Delugia Complete (No scaling of unicodes as expected)

Screenshot_2023-02-03_14-39-50

Delugia Book (Scaling of all other unicodes as expected except Powerline Extra Symbols)

Screenshot_2023-02-03_14-40-18

Caskaydia Cove (Scaling of unicodes as expected)

Screenshot_2023-02-03_14-41-24

Finii commented 1 year ago

Sorry to hear of your problems.

To make sure I understand you right... All the scaling in ok, bit with Delugia Book you expect the powerline glyph 'flames' to be wider (like 2 cells wide or so). At the moment it looks like scaled down in X direction to 1 cell. ?

Thanks for reporting, will investigate. Maybe I changed something at Nerd Fonts which I overlooked here.

Finii commented 1 year ago

Until 1b630a9266 we used Nerd Fonts v2.1.0.

After that

For v2111.01.1 we used Nerd Fonts v2.2.2 (Oct 2022) For v2111.01.2 we used Nerd Fonts v2.3.3 (Jan 2023)

image

This is not true since v2111.01.1.

PROxZIMA commented 1 year ago

All the scaling in ok, bit with Delugia Book you expect the powerline glyph 'flames' to be wider (like 2 cells wide or so).

By proportional font I assume that the unicodes maintain their original width throughout the process. So yes, in Delugia Book all other unicodes are scaled properly except the Powerline Extra symbols.

I'm afraid I found this issue in the last 10 releases of Delugia Book that I've tested so far.

Delugia Book v2111.01.1

image

I guess this issue is related to nerd fonts. In the 3rd image of https://github.com/adam7/delugia-code/issues/80#issue-1569500667 above (Caskaydia Cove), you can see unicode index 1864 to 1867 are monospaced as well. I've opened https://github.com/ryanoasis/nerd-fonts/issues/1106 for that.

Finii commented 4 months ago

Ah, of course, we use the original Cascadia Code Nerd Font glyphs and they are monospaced.

Hmm.

Just saw this too late and the new revision workflow is already running. :thinking: