search

adam7 / platformsh-cli-action

An unofficial GitHub Action for using the Platform.sh CLI
https://platform.sh/
MIT License
3 stars 2 forks source link

Include latest commits in potential v1.0.1. #11

Closed markdorison closed 3 years ago

markdorison commented 3 years ago

Based on the comment in .gitignore about "distribution branches" I am assuming you won't want to merge this to the master branch, but I am creating a PR just to add visibility and share that I used this branch to get things working while troubleshooting https://github.com/adam7/platformsh-cli-action/issues/10

adam7 commented 3 years ago

Thanks for the PR @markdorison, I'll try and review this and pull it to get the action working again 👍

adam7 commented 3 years ago

Instead of including node_modules it looks like a nicer approach would be to have a /releases branch and then package and add dist to that branch.

https://github.com/actions/typescript-action#publish-to-a-distribution-branch

markdorison commented 3 years ago

Thanks @adam7. I was not familiar with that release workflow. Closing in favor of #14

Once item to flag is that this workflow seems to prevent someone from pointing to a specific commit or branch to troubleshoot or obtain a fix not yet contained in a release since only the official releases and the release branch contains what is needed for the Action to run. Is that right or am I missing a workaround?