search

adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
39 stars 11 forks source link

Add capability for (identical) ensemble simulations #116

Closed stvdwtt closed 3 years ago

stvdwtt commented 3 years ago

This adds the capability for ensemble simulations. Currently they are all identical, but the ability to vary parameters will be added in a future PR.

Note: This has an odd issue where I can't call output_pvtu' directly on an element of a vector ofPostProcessor`, instead I have to make a copy. PostProcessor doesn't need a persistent state, so this works.

Rombur commented 3 years ago

It looks like there is an out-of-bound access triggered by test_integration_2d See here.

stvdwtt commented 3 years ago

Thanks -- I'm looking into it.

Rombur commented 3 years ago

Still failing :/ You know that there is clang on the docker image. You can take a look here how to get the sanitizer to work: https://github.com/adamantine-sim/adamantine/blob/master/ci/jenkins_config#L50-L71

Just make sure that the path to llvm-symbolizer is correct.

stvdwtt commented 3 years ago

@Rombur, thanks -- with that I was able to reproduce the segfault locally. Changing the postprocessor vector to a vector of unique_ptrs seems to work locally, although I'm not sure why it's different.