search

adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
36 stars 10 forks source link

Fix AMR bugs and add an AMR test #142

Closed stvdwtt closed 2 years ago

stvdwtt commented 2 years ago

The AMR bugs were fairly straightforward to fix. Back from #109, we were missing a call to get_state_from_material_properties() in refine_and_transfer(). Back from #135 there was a copy/paste error that set cos twice instead of cos then sin.

I also added an AMR integration/regression test.

stvdwtt commented 2 years ago

Gold values for the new test accidentally correspond to a different number of time steps that I was trying out. Will push a fix this morning.

stvdwtt commented 2 years ago

@Rombur, don't review/merge this yet -- I found another issue. I'm modifying the test to trigger it and then adding a prospective fix.

stvdwtt commented 2 years ago

@Rombur, I just created an issue (#143) for another AMR issue. If the checks pass for this PR, are you ok to merge this as-is and leave the fix for #143 in another PR?

Rombur commented 2 years ago

Yes, that's fine.