adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
32 stars 9 forks source link

Thermoelasticity with reference temperatures #209

Closed stvdwtt closed 1 year ago

stvdwtt commented 1 year ago

This PR does the following things:

stvdwtt commented 1 year ago

The CI failed, I'm going to look into it this afternoon. Oddly, it's passing on my machine. It could be an inconsistency between test input files in the repo and in my build directory.

Rombur commented 1 year ago

I don't know if you know but if you click on the Tests button on the top, you can see the error messages from the tests (see here). I don't think the problem is the input file. Are you using the latest version of the Docker image?

stvdwtt commented 1 year ago

I'm using the lastest version of rombur/adamantine-stack:latest, do you know if that has diverged from rombur/adamantine:latest?

Rombur commented 1 year ago

We use rombur/adamantine-stack:latest for the CI not rombur/adamantine:latest. rombut/adamantine:latest is automatically created when we merge a PR.

stvdwtt commented 1 year ago

I added a few more changes to address the errors in the CI.

Link to the new CI: https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/adamantine/detail/adamantine/338/pipeline/

stvdwtt commented 1 year ago

@Rombur, the CI passed and this is ready for review.

stvdwtt commented 1 year ago

I added the dummy MechanicalPhysics and I believe have addressed all of the review comments.

CI