search

adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
37 stars 10 forks source link

Remove dealii-weak_forms from the infrastructure #234

Closed Rombur closed 1 year ago

Rombur commented 1 year ago

This PR removes dealii-weak_forms. Everything seems to be working. The new code is very close to the old one. There is a FIXME that I will probably need help with.

CI

Rombur commented 1 year ago

@stvdwtt we can discuss the FIXME later (tomorrow?). The current code does the same thing as the old one so I think this can be merged as is.

stvdwtt commented 1 year ago

@Rombur: Oh, I misunderstood the comment then. So the code in the PR reproduces the old code behavior, but doesn't match an alternative formulation that you expect to give the same result? Talking tomorrow about it is a good idea. I'll merge this in.

Rombur commented 1 year ago

So the code in the PR reproduces the old code behavior, but doesn't match an alternative formulation that you expect to give the same result?

yes, exactly. You can manipulate the equation and get a simpler form but when I code it, I get a different result.