search

adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
32 stars 9 forks source link

Add lumps of material during deposition #238

Closed Rombur closed 9 months ago

Rombur commented 11 months ago

With this PR we can add more materials at once. I choose a deposition time parameter but we can pick something else. I don't know what's easier to use. One thing we need to be careful about is that our source term currently does not support multiple layers at the same time. So if we add too much material at the end of the layer the source term will be wrong.

CI

Rombur commented 11 months ago

DO NOT MERGE: I found a bug.

Rombur commented 11 months ago

This is ready for review but the CI was not triggered. I need to fix that before we can merge the PR

Rombur commented 11 months ago

The CI just started to work again by itself: CI

Rombur commented 9 months ago

Can you try again? I just rebased the branch, it seems to be working fine. When you merged with master, was your master up-to-date?

stvdwtt commented 9 months ago

My master was up to date, but this updated branch is working for me. Maybe your rebase did something different than when I merged?

In any case, this now works for me, so I'm merging it in.