adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
37 stars 10 forks source link

Fix parsing of the elastic limit #251

Closed stvdwtt closed 9 months ago

stvdwtt commented 10 months ago

MaterialProperty was checking each state for elastic_limit, and setting it to infinity if it wasn't there. The result was that the elastic limit for the solid was ignored.

This changes the logic so MaterialProperty only sets the elastic limit to infinity if it isn't listed for the solid.

Rombur commented 10 months ago

There is the same issue here: https://github.com/stvdwtt/adamantine/blob/c2e5642b1142f6856246c722a69f42c060ee0744/source/MaterialProperty.templates.hh#L923-L927 Can you fix it too.

stvdwtt commented 9 months ago

Retest this please.