search

adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
31 stars 9 forks source link

Remove embedded time stepping methods and Kelly estimator AMR #270

Closed Rombur closed 2 months ago

Rombur commented 2 months ago

This is the last PR I would like to get merged before creating the release branch. This removes the embedded time stepping methods (aka the adaptive time step method) and the AMR based on the Kelly estimator. We are not using either of these capabilities and they are making the code and the input file more complicated. The embedded method methods are problematic for the GPU computations and the Kelly estimator AMR is not usable in practice because the number of cells cannot be kept stable. We may reintroduce these capabilities in the future but we need to do it in a more thoughtful way.

Rombur commented 2 months ago

@stvdwtt ping

Rombur commented 2 months ago

Retest this please