adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
37 stars 10 forks source link

Automate CFL time step calculation #271

Open stvdwtt opened 5 months ago

stvdwtt commented 5 months ago

It should be straightforward to compute the global minimum time step for a simulation, assuming that we know the max thermal conductivity, the minimum coarse mesh element size, and the maximum number of refinements. This would allow us to make it so the user doesn't need to specifically pick the time step size, which would make things easier. We could add a user-specified safety factor so they can decrease the time step if desired.

Later on we could do a more sophisticated version of this where we adapt based on the layer that we're on, but that's out of scope for now.

Rombur commented 5 months ago

This should be high on our priority list. Right now it's really difficult for users to pick a good time step a priori. It's really cumbersome to use adamantine with Slicer 2

stvdwtt commented 3 weeks ago

Note to myself here, use dealii.GridTools::minimal_cell_diameter().