search

adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
31 stars 9 forks source link

Updates for deal.II master past 9.5 #281

Open masterleinad opened 2 months ago

masterleinad commented 2 months ago

https://github.com/dealii/dealii/pull/16745 updated the SolverGMRES implementation and deal.II/lac/la_vector.h was removed in https://github.com/dealii/dealii/commit/d22e218017b8577437eb4fd36315dc6bf8653988.

Rombur commented 2 months ago

I've thought about this before and I don't want to support multiples versions of our dependencies. We do it at one place but retrospectively this was a mistake because we never check that path. Supporting multiples versions of our dependencies makes maintaining and testing the code more complicated and we gain nothing from it.

masterleinad commented 2 months ago

The advantage I am seeing is that it is more difficult to add features to deal.II or work on implementation details for, say, the portable matrix-free, if the code doesn't support deal.II master. Also, the README, says

Installing adamantine requires:

  • MPI
  • A compiler that support C++17
  • CMake: 3.15 or later
  • Boost: 1.70.0 or later
  • ArborX: 1.4.1 or later
  • Trilinos: 14.4.0 or later
  • deal.II: 9.5 or later
Rombur commented 2 months ago

I am fine having this PR in the release branch because it's not a long-term burden but not in master. Unless there is a very good reason to support multiple versions, I do not want to do it.

work on implementation details for, say, the portable matrix-free

This is not a priority for this FY. There are other things more impactful that need to be done.