adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
31 stars 9 forks source link

Avoid compiler warnings #287

Closed masterleinad closed 1 month ago

masterleinad commented 1 month ago

While working on #282, I noticed that there are more warnings which this pull request fixes. I wasn't sure if we wanted to enforce this with -Werror or similar.

Rombur commented 1 month ago

@Rombur, any concerns?

Yes, don't merge it. I will do a proper review later but we should not merge as is.