search

adamantine-sim / adamantine

Software to simulate heat transfer for additive manufacturing
https://adamantine-sim.github.io/adamantine/
Other
31 stars 9 forks source link

Add support for the on-the-fly update of the scan path #291

Closed Rombur closed 1 month ago

Rombur commented 1 month ago

@stvdwtt can you try this PR. With it you shouldn't need to restart adamantine to update the scan path.

stvdwtt commented 1 month ago

This works for expected with the scan path: if I swap the scan path file before the simulation gets to the end of the initial scan path file it will load the updated scan path and do the full scan path.

One thing before I approve and merge -- are you intentionally saving recalculation of material addition for a second PR? Because it looks like only the material from the initial scan path gets deposited.

Rombur commented 1 month ago

One thing before I approve and merge -- are you intentionally saving recalculation of material addition for a second PR? Because it looks like only the material from the initial scan path gets deposited.

No, it's a copy/paste error. Can you remove the auto at line 1043 of adamantine.hh and try again

Rombur commented 1 month ago

Sorry replace the auto by std::tie(...)