search

adamantoise / robocrosswords

Robo Crosswords app for Android
Other
39 stars 19 forks source link

Not sure if you're interested in german-language puzzle sources #2

Closed LittleLui closed 10 years ago

LittleLui commented 10 years ago

Hi Adam,

I've added a Downloader for the austrian newspaper derStandard.at, which has a wonderfully quirky, punny and weird crossword puzzle (albeit in german).

i'm not sure if you're interested in adding further puzzle sources, or even non-english language ones. If you are, I'd clean this up a bit and integrate it into the options (currently this is only for my personal use and as this is the only puzzle source i actually use, is not user-changeable).

best regards and thanks for this wonderful program LittleLui

adamantoise commented 10 years ago

Hi LittleLui,

While there's not been much demand (any, really) for non-English puzzles so far, I'd be happy to review it and merge it in if it were cleaned up a bunch and integrated nicely.

LittleLui commented 10 years ago

Hi Adam,

I fixed some bugs, cleaned up the code a bit, added a check box to the preferences and added a GPL reference header to all the files I added.

I'd welcome any comments and criticism, especially if there's something specific you want to be changed before being merged.

(And by the way, THANK YOU for maintaining this wonderful app, I use it almost daily)

LittleLui commented 10 years ago

Thanks for the review. I think I managed to include all the changes you suggested.

adamantoise commented 10 years ago

I've merged this in, but I made a number of changes (fixed some warnings, some small refactoring, etc.), and I've also disabled the automatic downloader for this by default, since I suspect most English speakers won't want German-language crosswords. Feedback welcome.

I have very minor worry that the DerStandardDownloader.ser state file will continue growing without bound over time as more entries go into the cache, resulting in more and more I/O to read/write it, but it's so little data overall that I don't think it's every going to be a concern. If you have any ideas on how to improve it, I'm open to suggestions.