search

adamayoung / TMDb

The Movie Database Swift Package
https://adamayoung.github.io/TMDb/documentation/tmdb
Apache License 2.0
112 stars 29 forks source link

Change multipathServiceType to none #183

Closed chickdan closed 5 months ago

chickdan commented 5 months ago

I tried out this SDK for the first time today but spent hours trying to determine why I wasn't getting a response. Drilling down I came across configuration.multipathServiceType = .handover. I was curious what that is since I have not used it before and reading the docs I saw that it Requires the com.apple.developer.networking.multipath entitlement.

Using these service types requires the appropriate entitlement. Any connection attempt will fail if the process does not have the required entitlement.

This explained all of my problems and confirmed as such with the change of this PR.

My suggestion, given this SDK will likely be most used by developers working on hobby projects, is to switch this to .none so that the entitlement is not required. However, if this setting is a hard requirement for the SDK I can change this PR to instead emphasize the need for the entitlement in the README.

adamayoung commented 5 months ago

Thanks for spotting this @chickdan. Haven't come across this issue myself.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.15%. Comparing base (db60901) to head (79b7234).

Files Patch % Lines
Sources/TMDb/TMDbFactory.swift 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #183 +/- ## ======================================= Coverage 89.15% 89.15% ======================================= Files 198 198 Lines 2721 2721 ======================================= Hits 2426 2426 Misses 295 295 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

movesmyers commented 5 months ago

I am hoping this is a fix for #125. thank you @chickdan !