search

adamayoung / TMDb

The Movie Database Swift Package
https://adamayoung.github.io/TMDb/documentation/tmdb
Apache License 2.0
112 stars 29 forks source link

FEATURE: TVShow Content Ratings #188

Closed chickdan closed 3 months ago

chickdan commented 4 months ago

Adding support for this endpoint

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (868a1ad) to head (68c3e1d).

Files Patch % Lines
...MDb/Domain/Services/TVSeries/TVSeriesService.swift 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #188 +/- ## ========================================== - Coverage 89.47% 89.47% -0.01% ========================================== Files 201 203 +2 Lines 2804 2822 +18 ========================================== + Hits 2509 2525 +16 - Misses 295 297 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamayoung commented 4 months ago

Hey @chickdan - just need to add a few more tests to bump the code coverage of your changes about 60% 🙏🏻

chickdan commented 3 months ago

@adamayoung thank you for your patience. I've expanded the test coverage for this feature, although I'm not sure why TVSeriesService.swift is reporting as two lines not covered when I added an integration test. That said, it looks like watchProviders() has the same issue.