adambard / learnxinyminutes-docs

Code documentation written as code! How novel and totally my idea!
https://learnxinyminutes.com/
Other
11.31k stars 3.28k forks source link

[javascript/en] var -> let/const #4707

Open sjrct opened 1 year ago

sjrct commented 1 year ago

In the javascript tutorial the var keyword is introduced and used extensively, while let and const are only mentioned briefly under the ES6 additions section at the end. In this day and age, where ES6 is support is extremely common and use of var is essentially entirely been supplanted by let and const, wouldn't it make more sense to have var be the footnote instead?

I can make this change, I just want to see what ppl think

wandrey7 commented 3 months ago

You have a good idea, but it would be ideal to leave the var because there are still many projects that use it, this is indispensable when learning javascript. We would then have var, let and const

sjrct commented 2 months ago

ES6 which introduced let/const which made var obsolete has been out since 2015, almost a decade. I agree that var is still used plentifully and should be discussed, but I really do think that the primacy should be given to let & const and var should be the afterthought?

bartdorsey commented 1 month ago

Definitely introduce var, let and const, but if the example is not illustrating var, it should use let.