search

adambielski / siamese-triplet

Siamese and triplet networks with online pair/triplet mining in PyTorch
BSD 3-Clause "New" or "Revised" License
3.09k stars 634 forks source link

Fixed test pair exclusion from train pairs #40

Closed wconnell closed 4 years ago

wconnell commented 4 years ago

It seems to me that the fixed test pair set is not guaranteed to be excluded in the random training pairs generated from the SiameseMNIST class.

Is this is correct this will be causing leakage, no? With high probability in small sample sizes.

wconnell commented 4 years ago

Not the case given the test set is comprised of independent unseen samples