search

adambielski / siamese-triplet

Siamese and triplet networks with online pair/triplet mining in PyTorch
BSD 3-Clause "New" or "Revised" License
3.1k stars 633 forks source link

a question about tripletloss #43

Closed Sword-keeper closed 4 years ago

Sword-keeper commented 4 years ago 
    Nice code ! I learned a lot from you code. However, I still have a question about  class 'EmbeddingNet' in the networks.py .
    I noticed that, the output's size of the 'EmbeddingNet'  is (2). So I worried about the embedding of input sample  is too small. And when we use this embedding  to caculate the triplet loss. It may have  some problem.
adambielski commented 4 years ago

This is just for visualization, as mentioned in readme. You should use a bigger embedding size in practice.