search

adambisek / string-pixel-width

Blazingly fast measure string width in pixels on the server in Javascript (Node.Js)
https://medium.com/@adambisek/text-pixel-width-measuring-on-javascript-backend-node-js-2b82bea97fab#.8ypyiffyw
MIT License
103 stars 41 forks source link

Add Helvetica #12

Closed adambrgmn closed 5 years ago

adambrgmn commented 5 years ago

Hi, Thanks for an interesting package which fits my use case perfectly! I took the liberty of adding Helvetica as a new font.

All tests pass and I've only added the new font without changing any of the already existing.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 89ff908414da2a5710f61b98b738acaff2fed2b5 on adambrgmn:add-font-helvetica into bfa58607753761ac88795b6e740252343b9f5567 on adambisek:master.

adambisek commented 5 years ago

Thank you for your contribution :) Version 1.9.0 has just been released.

adambrgmn commented 5 years ago

Thanks! That was quick!

adambrgmn commented 5 years ago

Oh, and one thing I missed – I forgot to add Helvetica to the supported fonts section in README. Want me to PR just for that or maybe you want to add it in later?

adambisek commented 5 years ago

Oh, yes. PR would be great :)