search

adambrgmn / react-oauth-flow

An OAuth2 flow for React apps
MIT License
94 stars 37 forks source link

Component has required props which are not relayed correctly to server #30

Open stuartedward opened 6 years ago

stuartedward commented 6 years ago

Hello! Trying to use this for Evernote authentication. The component requires a value for clientId but this doesn't match to the oauth_consumer_key required by Evernote. How can I map these correctly? Is it necessary to set clientID to an empty string and pass the other queries in via the arguments prop?

adambrgmn commented 6 years ago

Hi, As you might have understood this package is quite opinionated and developed for my needs. I have never worked with Evernotes auth-service and was under the impression that all OAuth2 services worked similarily.

I'll have to dig into this. But your solution sounds reasonable. Maybe, if you try it out you'll spot some things that needs to be fixed and would like to submit a PR?

adambrgmn commented 6 years ago

(And ignore the mention in the last commit commit, I slipped 😃)