search

adambullmer / vue-cli-plugin-browser-extension

Browser extension development plugin for vue-cli 3.0
GNU Lesser General Public License v3.0
427 stars 76 forks source link

Locales support #24

Closed matrunchyk closed 5 years ago

matrunchyk commented 5 years ago

Is it possible to have locales support?

I think it needs to add an extra CopyWebpackPlugin usage for _locales folder and maybe an extra check for pluginOptions.manifestSync.includes('default_locale').

Awesome plugin, thank you!

adambullmer commented 5 years ago

Made a pull request enabling some basic support for locales. It handles some of the scaffolding, but Vue's default behavior of copying anything in the public directory into the root of the dist directory is really the only feature needed to enable internationalization. If you could make sure this behaves like you expect, I can get this merged and released.

Thank you for the suggestion!

matrunchyk commented 5 years ago

Thank you, the PR looks great to me! 😀