search

adambullmer / vue-cli-plugin-browser-extension

Browser extension development plugin for vue-cli 3.0
GNU Lesser General Public License v3.0
427 stars 76 forks source link

Fixing modern mode naming to align with base vue conventions #67

Closed adambullmer closed 4 years ago

adambullmer commented 5 years ago

Also ensure plugin exists before tapping. fixes #61

naokazuterada commented 4 years ago

I have similar error with https://github.com/adambullmer/vue-cli-plugin-browser-extension/issues/61

TypeError: Cannot read property '0' of undefined

on vue-cli-plugin-browser-extension/index.js:117:14 vue-cli-plugin-browser-extension version: 0.24.0 (updated from 0.15.1 recently)

@adambullmer

Hi, thanks for great package!

Also ensure plugin exists before tapping.

This PR may fix my problem. Why didn't you merge this ? Anything problem?

adambullmer commented 4 years ago

Only reason was waiting for confirmation from the issue creator that this does indeed fix the problems they encountered before merging. But sounds like you can confirm that for me, yes?

adambullmer commented 4 years ago

Released in v0.24.1

naokazuterada commented 4 years ago

@adambullmer Thanks! Now it work well with v0.24.1 in my case.

naokazuterada commented 4 years ago

@adambullmer In my case, only these updates might be needed just in a case. 😄