search

adamburmister / gitprint.com

Render Github markdown documents for printing
346 stars 28 forks source link

Links in pages aren't links in the PDF #17

Open j-h-a opened 10 years ago

j-h-a commented 10 years ago

Links are split out into a separate bit of text. The default should be to have the link text as an actual link. There could be an option for how to handle links:

  1. So it looks exactly the same as the GitHub page - a blue link with the URL not visible. (default)
  2. Split it out to separate text (current)
  3. Add a footnote (might be problematic, but it's an idea).
adamburmister commented 10 years ago

@j-h-a Thanks for taking the time to log all these. I appreciate the effort of contributing back ideas. I'll look over them all and assign them to a release. (Although some of them look like they're as-designed [I didn't intend it to be a straight conversion of Github's style]).

Regarding this issue: I think we could probably get this working.

adamburmister commented 10 years ago

See https://github.com/ariya/phantomjs/issues/10196

jgarzik commented 10 years ago

Ditto. I'm seeing this issue also. See e.g. https://github.com/jgarzik/bitcoin/blob/2014_process_doc/doc/devel-process.md and its gitprint counterpart.

antimodular commented 9 years ago

i second these ideas. i find it confusing that the pdf does not have the same look for links as the regular markdown file has. pls add this feature.

same goes for email addresses.

thanks