search

adamburmister / gitprint.com

Render Github markdown documents for printing
346 stars 28 forks source link

Missing sort of images #27

Open yangboz opened 10 years ago

yangboz commented 10 years ago

Hi,

My markdown files is too long with a lot of image files, sort of images missing in the final PDF result, does this issue caused by out of memory for image storage?

Testing Markdown file address: https://gitprint.com/yangboz/laughing-nemesis/blob/master/EN_US.md

Best, Yangbo

adamburmister commented 10 years ago

I think it's probably that there's not enough delay between loading the page, rendering the HTML and converting it to PDF... so the images didn't all have time to load.

I'm not entirely sure what the solution is - the lib I'm using for the MD->PDF conversion has this constant delay baked into it, so there doesn't appear to be a "done rendering everything" event that we can use to trigger the PDF conversion.

adamburmister commented 10 years ago

Just an idea: maybe I could count the number of images within the MD first, download them locally perhaps, update the references to the local URL.

Will ponder on it.

Anyone else please feel free to pick it up :)

Crocmagnon commented 9 years ago

Hi, I can confirm this issue, and it's quite annoying. See this file for example : https://gitprint.com/getify/You-Dont-Know-JS/blob/master/up %26 going/ch1.md