search

adamburmister / gitprint.com

Render Github markdown documents for printing
345 stars 28 forks source link

Does not print images of github wiki pages #32

Open dkapoor opened 9 years ago

dkapoor commented 9 years ago

It just inserts text like this: [[images/invoke-service-menu.png|center|frame|Invoking a service from a Karma worksheet]]

Pilooz commented 9 years ago

Same problem with markdown files. This should be great that the relative links like this one : ![My Image](./images/fmy-image.png) could appear in final pdf. For the moment, it seems that the pdf displays only a white filled grey bordered rectangle . :+1: for this feature !

NVentimiglia commented 9 years ago

Can confirm, I have a white filled grey bordered rectangle .

markusmo3 commented 9 years ago

+1 for this feature, wanted to use gitprint to print the awesome Java Design Patterns by iluwater

NVentimiglia commented 9 years ago

Work around. You can select the wiki text, hit print, then select pdf. Using Chrome I received an acceptable pdf file. Its annoying on longer wiki's but if it is single page it is fine.

yangzhaox commented 8 years ago

I had a similar issue and here is my solution.

  1. ignore ssl errors when calling phantomjs in module markdown-pdf. See my last two commits in: my clone
  2. in package.json of gitprint, replace markdown-pdf with the one in step 1
  3. adjust WAIT_FOR_RENDER_DELAY to a longer time, say 5000 for example in line 17 of: gitprint
adamburmister commented 8 years ago

Thanks for the hints up @jensonzhao

I need to rewrite the whole thing, so am just waiting to find some time. If anybody has time and wants to make PRs they would be gratefully accepted.

yangzhaox commented 8 years ago

@adamburmister I sent you a PR in markdown-pdf repo.