adamburmister / gitprint.com

Render Github markdown documents for printing
346 stars 28 forks source link

images do not appear on gitprint page and do not print #38

Open antimodular opened 9 years ago

antimodular commented 9 years ago

for example this readme file has an image in it. https://github.com/tgfrerer/ofxPlaylist/blob/master/Readme.md

But on gitprint the image does not appear. https://gitprint.com/tgfrerer/ofxPlaylist/blob/master/Readme.md

same things happens in safari and chrome.

why? thanks.

pcperini commented 9 years ago

:+1: I've tried both relative and absolute URLs for images, and neither render.

adamburmister commented 9 years ago

Thanks - I think the recent Github update might have changed their implementation which we are relying on. I've flagged this as a bug for fixing in a future release.

If anyone has time PRs would be appreciated

pcperini commented 9 years ago

@adamburmister I'd love to take a look at this if you could point me to where the old image code is :smiley:

zulhfreelancer commented 8 years ago

+1

leros commented 8 years ago

any progress?

yangzhaox commented 8 years ago

It could be caused by ssl error when accessing the image. See my reply in another issue: #32

eonist commented 8 years ago

+1 all my images are sourced from dropbox

ThisIsTian commented 8 years ago

any progress?

adamburmister commented 7 years ago

Hi all – This one keeps coming up! I'm putting in some hours over the holiday break to rewrite Gitprint into a more modern, up to date design. I'll be attempting to tackle this bug fix with some updates.

Crissov commented 7 years ago

Is there any update on this? It doesn't make sense to develop a PR for this bug if you'll be releasing a completely overhauled version soon.

Looking at the code commits makes it seem like this project has been dormant for three years, i.e. is effectively dead. Your activity in issue threads give me some hope.

eonist commented 7 years ago

@Crissov I use Atom.io Markdown preview. Save html. Open in safari. Save pdf. Love this project tho. The auther should put up a patreon to get some funds to move it along.

ElectronHarvester commented 7 years ago

Issue again on 7/8/2017

robertfmurdock commented 7 years ago

Love this project, but I'd also love to have this issue resolved... love me some rich markdown. Thanks again for making this thing @adamburmister!

darvin commented 4 years ago

same here

Adpaar commented 3 years ago

Same here