search

adambutler / vuejs-rails

A simple asset-pipeline wrapper for Vue.js by Evan You
MIT License
429 stars 56 forks source link

Update assets to Vue 2.5 #45

Closed YurySolovyov closed 6 years ago

YurySolovyov commented 6 years ago

I didn't update vuex and vue-router to latest because there were semver-major changes with regards to typescript and I'm not sure how do we want to deal with them.

YurySolovyov commented 6 years ago

Hm, I think it does, or you mean something else?

joshminnie commented 6 years ago

Sorry, should have been more clear.

You made the comment about the semver major changes with regards to typescript. I was hoping to see more about that in the README for those who might not know why they were not the latest version.

YurySolovyov commented 6 years ago

Well, this particular PR does not yet contain semver-major stuff, so I guess we can mention it when we actually introduce these new assets

phoet commented 6 years ago

my assumption was that it would be safe to include the changes that break TS. wouldn't the TS compiler notice the incompatibilities?

YurySolovyov commented 6 years ago

Good point. /cc @adambutler @kimyu92

phoet commented 6 years ago

i think that this can be closed now