search

adamchainz / gargoyle

:radio_button: Feature switches in Django
Apache License 2.0
109 stars 19 forks source link

Fix import error in documentation build. #198

Closed AgDude closed 6 years ago

AgDude commented 6 years ago

In particular this impacts the ConditionSet API documentation.

This will cause documentation builds on older Django versions to fail (<1.9 I think).

AgDude commented 6 years ago

It turns out I was mistaken. django.setup was added in 1.8, so this should already work.

adamchainz commented 6 years ago

Docs just built on https://gargoyle-yplan.readthedocs.io/en/latest/ , thanks

AgDude commented 6 years ago

It looks like on RTD the build is still failing. The api docs here are missing: https://gargoyle-yplan.readthedocs.io/en/latest/ref/conditions.html#. This branch worked for me to build the docs locally.

adamchainz commented 6 years ago

Fixed the build in #204 / #205. Turns out the import error is just a warning so doesn't fail the build :(