Closed adamcharnock closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.07%. Comparing base (
81b90df
) to head (390bd5c
). Report is 6 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@adamcharnock thanks for this, I am planning on taking a look at this as soon as I have some spare capacity and will see how difficult it is to implement your improvements in the mysql version.
Hey @Joshun! I realise now I didn't make this clear in my update – This did in-fact include a MySQL port of the changes. That being said I would certainly appreciate you looking over my work there as I haven't touched MySQL for quite a while.
I think this should drastically speed up the generation of full account codes.
The old:
O(n**2)
operationThe new:
NULL
or""
will cause all child full account codes to beNULL
.Caveat:
I've not ported this optimisation to. @Joshun, if you're still around I'd very much welcome your assistance here (or anyone else for that matter). Lack of this wont block merging though. Update: done, grumbles.mysql
And tagging @PetrDlouhy (#40), FYI.