adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
228 stars 55 forks source link

Account code regeneration major performance improvement #117

Closed adamcharnock closed 1 month ago

adamcharnock commented 1 month ago

I think this should drastically speed up the generation of full account codes.

The old:

The new:

Caveat:

And tagging @PetrDlouhy (#40), FYI.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.07%. Comparing base (81b90df) to head (390bd5c). Report is 6 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #117 +/- ## ========================================== + Coverage 93.01% 93.07% +0.05% ========================================== Files 59 61 +2 Lines 3836 3940 +104 Branches 249 256 +7 ========================================== + Hits 3568 3667 +99 - Misses 224 227 +3 - Partials 44 46 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Joshun commented 1 month ago

@adamcharnock thanks for this, I am planning on taking a look at this as soon as I have some spare capacity and will see how difficult it is to implement your improvements in the mysql version.

adamcharnock commented 1 month ago

Hey @Joshun! I realise now I didn't make this clear in my update – This did in-fact include a MySQL port of the changes. That being said I would certainly appreciate you looking over my work there as I haven't touched MySQL for quite a while.