search

adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
239 stars 55 forks source link

Check for missed migrations #15

Closed sutyrin closed 6 years ago

sutyrin commented 6 years ago

Yep, this check seems to give valuable feedback ;)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 95.408% when pulling 1ffeda5058037595051672911b18bbe4558304a2 on pavel64-sutyrin:master into f7bda727d9741cb811e83bfb40f31353c9730342 on adamcharnock:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 95.408% when pulling 1ffeda5058037595051672911b18bbe4558304a2 on pavel64-sutyrin:master into f7bda727d9741cb811e83bfb40f31353c9730342 on adamcharnock:master.

adamcharnock commented 6 years ago

Thanks @pavel64-sutyrin, this is a good check to do. Travis doesn't seem too happy though. I'm a bit busy right now, but if you can make travis happy I'll merge immediately.

sutyrin commented 6 years ago

It's deeper than it seems. Django verisions have opinions on these transactions. Not urgent for me personally, but will definitely strenghten library for everyone)

adamcharnock commented 6 years ago

Hi Pavel,

I've merged this change in and put in place a workaround to the 'breaks on some django versions' problem.

Travis seems happy now, and at least we'll now catch cases where migrations have not been created.

Thank you very much for the PR.