adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
239 stars 55 forks source link

make account code unrequired #20

Closed PetrDlouhy closed 6 years ago

PetrDlouhy commented 6 years ago

This is my attempt to address issue #13. I don't know what are the codes used for, so I am not sure if it doesn't break anything. But basic things seem to work for me.

I use django-hordak to make account for every user, so it would be quite difficult creating codes for all of them (and maybe impossible due to the possible number of codes).

adamcharnock commented 6 years ago

Thank you for this @PetrDlouhy! I'm taking a look now. I'll probably push some changes onto this pull request if that is ok with you?

adamcharnock commented 6 years ago

BTW, I just rebased this off master, because I'd forgotten to merge the django2 branch into master, and as a result this PR was missing some Django migrations.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.04%) to 95.446% when pulling 8e73ae707e573e9529cdf82abed984ac76bd6ba7 on PetrDlouhy:unrequired_codes into 508da63039d14a29820e4aa94a459f8cafcad7ca on adamcharnock:master.

adamcharnock commented 6 years ago

Hey @PetrDlouhy, I've pushed a few commits to just wrap up this change. These commits:

Next steps:

  1. Wait for travis to finish building
  2. Can you feedback on these changes? Do they work for you?

Once the above are done I'll be happy to merge.


Importantly: You'll need to re-run migration 24 as I have modified the steps within it:

# Rollback to migration 23
./manage.py migrate hordak 0023
# Reapply 24
./manage.py migrate hordak 0024
PetrDlouhy commented 6 years ago

@adamcharnock Nice. So far it seems, that it is working perfectly.

adamcharnock commented 6 years ago

I'm glad to hear @PetrDlouhy! I'll merge it in then, thank you for the PR! 👍

adamcharnock commented 6 years ago

I've just released 0.8.0