search

adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
239 stars 55 forks source link

Test fails due to incorrect positioning of Euro currency symbol and wrong decimal separater (child of #29) #32

Closed p-baum closed 5 years ago

p-baum commented 5 years ago

Separate fix for #29 as requested.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 95.463% when pulling 22328061eb164a88bc287256ed1b609f8dfa957e on p-baum:issue-29 into a6e249d0c48f9f5cb38b82739432457d647afdf1 on adamcharnock:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 95.463% when pulling 22328061eb164a88bc287256ed1b609f8dfa957e on p-baum:issue-29 into a6e249d0c48f9f5cb38b82739432457d647afdf1 on adamcharnock:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 95.463% when pulling 22328061eb164a88bc287256ed1b609f8dfa957e on p-baum:issue-29 into a6e249d0c48f9f5cb38b82739432457d647afdf1 on adamcharnock:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 95.463% when pulling 22328061eb164a88bc287256ed1b609f8dfa957e on p-baum:issue-29 into a6e249d0c48f9f5cb38b82739432457d647afdf1 on adamcharnock:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.003%) to 95.466% when pulling c4b2c1135eae583cb4152354c92c36cefea557cb on p-baum:issue-29 into a6e249d0c48f9f5cb38b82739432457d647afdf1 on adamcharnock:master.

adamcharnock commented 5 years ago

Thanks for generalising this fix to a regex @p-baum.

I've actually gone a step further as, on reflection, I figured this test didn't really need to be testing the currency formatting anyway. It only needs to know that the formatted value would be displayed. I'm happy to assume that the babel library has its currency formatting well tested. I've made another commit on this PR, can you take a look and let me know what you think?

p-baum commented 5 years ago

It looks better than my quick fix. Its no biggie. Whatever.