search

adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
231 stars 55 forks source link

Is this library maintained? #35

Closed coler-j closed 5 years ago

coler-j commented 5 years ago

As title.

adamcharnock commented 5 years ago

Hi @coler-j, it is indeed maintained. However, as you can see, my check-ins with the project can be sporadic.

I am however very ammenable to receiving pull requests which have passing tests. I would also be very interested in turning such contributors into maintainers should they be interested.

coler-j commented 5 years ago

Sounds good! Glad you are back. I was reviewing the code, and have noticed that you are using DB triggers but that they are not really documented anywhere. Is there somewhere that goes over the triggers that are in place? Or is there somewhere that I can pull this information from so that I can document it for you?

adamcharnock commented 5 years ago

Hey @coler-j, that is a very kind offer, thank you! The triggers are not actually documented anywhere. The most reliable view of them would be to run the migrations to create a local database use a database inspector of some sort to view the results.

I agree that documenting them would be a good idea, and it would also hopefully highlight some errors. I know #34 highlights one of these, but #33 implies/discussed further improvements and fixes. The most crucial triggers are tested via the django tests. However, some triggers have clearly escaped this testing.

I certainly welcome documentation of these triggers. If you decide to do so then I suggest creating a new page in the docs for it.

coler-j commented 5 years ago

Ok thanks, I am digging into it tomorrow to gain understanding and will add to the docs, I will try and get a PR in tomorrow with it.

On Thu, Mar 7, 2019, 5:49 PM Adam Charnock, notifications@github.com wrote:

Hey @coler-j https://github.com/coler-j, that is a very kind offer, thank you! The triggers are not actually documented anywhere. The most reliable view of them would be to run the migrations to create a local database use a database inspector of some sort to view the results.

I agree that documenting them would be a good idea, and it would also hopefully highlight some errors. I know #34 https://github.com/adamcharnock/django-hordak/issues/34 highlights one of these, but #33 https://github.com/adamcharnock/django-hordak/pull/33 implies/discussed further improvements and fixes. The most crucial triggers are tested via the django tests. However, some triggers have clearly escaped this testing.

I certainly welcome documentation of these triggers. If you decide to do so then I suggest creating a new page in the docs for it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamcharnock/django-hordak/issues/35#issuecomment-470730959, or mute the thread https://github.com/notifications/unsubscribe-auth/AHeff_5md2Zs-7WEf0rGokLESxQLUzJoks5vUZeVgaJpZM4bh4zm .

coler-j commented 5 years ago

Docs added in https://github.com/adamcharnock/django-hordak/pull/36