adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
231 stars 55 forks source link

Why is Account code field only 3 digits? #41

Closed ajaff closed 2 weeks ago

ajaff commented 5 years ago

Really useful library - just a few questions: As title - why is the code field only 3 digits - this limits us to ~1000 accounts per node. Is this a performance reason? What is the recommended workaround?

adamcharnock commented 5 years ago

Hi @ajaff, I'm glad you're finding it useful! There is no reason for the limitation, and in fact the account codes are the source of a number of bugs (and are of questionable use), so I'm likely going to remove them in the next major version of Hordak.

However, until then, I believe you can also use A-Z characters in the account codes, which will give you 36^3 accounts per node.

ajaff commented 5 years ago

Ah understood, didn't realize alphabetical characters work. Actually having a account code (not pk) is pretty standard for a general ledger, maybe it can just be a informational field though.

Different account types have different codes. https://smallbusiness.chron.com/general-ledger-codes-58774.html

On Sun, Jun 16, 2019, 4:16 AM Adam Charnock notifications@github.com wrote:

Hi @ajaff https://github.com/ajaff, I'm glad you're finding it useful! There is no reason for the limitation, and in fact the account codes are the source of a number of bugs (and are of questionable use), so I'm likely going to remove them in the next major version of Hordak.

However, until then, I believe you can also use A-Z characters in the account codes, which will give you 36^3 accounts per node.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamcharnock/django-hordak/issues/41?email_source=notifications&email_token=ACOJUPBM2EKA5OCFDPCULLTP2YOHVA5CNFSM4HYOOORKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZKXEY#issuecomment-502442899, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOJUPGZNBHHCPSKVA4GZ73P2YOHVANCNFSM4HYOOORA .

adamcharnock commented 2 weeks ago

Now tracked in #122