search

adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
231 stars 55 forks source link

New migration 0027 being automatically generated by makemigrations #45

Closed jordanmkoncz closed 4 years ago

jordanmkoncz commented 4 years ago

Whenever I run python manage.py makemigrations, I'm seeing the following output in console:

Migrations for 'hordak':
  /usr/local/lib/python3.7/site-packages/hordak/migrations/0027_auto_20200110_0920.py
    - Alter field amount on leg
    - Alter field amount_currency on leg

It seems like django-hordak is missing a new migration, which I assume is related to an update to django-money since migrations were last generated. My currently installed requirements are:

py-moneyed==0.8.0
django-money==1.0
django-mptt==0.10.0
django-hordak==1.9.0

Unfortunately I can't paste the contents of this migration that's being automatically generated since I'm running my project using Docker and can't find a way to view this file.

Side note: just want to say a big thanks for creating this package, it's awesome and has saved me a huge amount of time!

adamcharnock commented 4 years ago

Hi @jordanmkoncz!

Side note: just want to say a big thanks for creating this package, it's awesome and has saved me a huge amount of time!

I'm very glad! It is always great to hear from someone using one of my projects :-)

I've just tried to recreated this. I deleted my (very old) virtual environment and recreated it fresh. I had for force Django<3 (as it looks like Hordak needs some fixes for Django 3). However, when I run makemigrations I get No changes detected.

My full pip freeze output is:

asgiref==3.2.3
Babel==2.5.1
certifi==2019.11.28
chardet==3.0.4
defusedxml==0.6.0
diff-match-patch==20181111
dj-database-url==0.5.0
Django==2.2.9
django-extensions==2.2.5
django-hordak==1.9.0
django-import-export==2.0
django-js-asset==1.2.2
django-model-utils==4.0.0
django-money==1.0
django-mptt==0.10.0
django-smalluuid==1.1.1
et-xmlfile==1.0.1
idna==2.8
jdcal==1.4.1
MarkupPy==1.14
odfpy==1.4.0
openpyxl==3.0.2
psycopg2-binary==2.8.4
py-moneyed==0.8.0
pytz==2019.3
PyYAML==5.3
requests==2.22.0
six==1.13.0
smalluuid==1.0.0
sqlparse==0.3.0
tablib==0.14.0
urllib3==1.25.7
xlrd==1.2.0
xlwt==1.3.0

Can you use this to figure out what may be causing this on your side?

jordanmkoncz commented 4 years ago

@adamcharnock interesting, it must be something on my end then I guess. I'll look into this more when I have a chance. :)

falbellaihi1 commented 4 years ago

I've just tried to recreated this. I deleted my (very old) virtual environment and recreated it fresh. I had for force Django<3 (as it looks like Hordak needs some fixes for Django 3). However, when I run makemigrations I get No changes detected.

@adamcharnock thank you for creating this package,

I am actually using Django 3 and have no issues with it, I just had to update few things to make it compatible. I am still testing and until now nothing occurred 👍

adamcharnock commented 4 years ago

No worries @jordanmkoncz, and thank you for the confirmation @falbellaihi1.

I'll close this for now, but definitely reopen it if the problem can be recreated.